ci: check for linting errors without writing required changes #2357
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeg
added
tests
|
📝 Here are the updated logs! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 36 36
Lines 7472 7472
Branches 653 653
=======================================
Hits 6919 6919
Misses 545 545
Partials 8 8 ☔ View full report in Codecov by Sentry. |
2 tasks
hello-ashleyintech
approved these changes
Dec 5, 2024
|
@hello-ashleyintech how darned opionated linters can be. I'm hoping that'll be caught more often. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
lint:fixjob to write changes needed for linting to pass. Thenpm run lintcommand is changed to just check for changes. That'll cause CI to fail if changes are needed!This matches the changes discussed in: slack-samples/bolt-ts-starter-template#131
Preview
Before changes
https://github.com/slackapi/bolt-js/actions/runs/12171290321/job/33947916208#step:5:19
After changes
Found in the action logs of this PR!
Notes
Planning to follow up with the same changes to
node-slack-sdkas needed 🙏Requirements